feat: toggle_floating_state and is_floating (#306) #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminez
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Implementation looks good 👍
If you can add some teats for the toggle method then this should be good to merge.There are equivalent tests for similar methods in the file already using the test_case macro to cover the different cases you highlight in the doc comment.
src/pure/stack_set.rs
Outdated
Comment on lines
819
to
824
| Ok(if self.is_floating(&client) { | ||
| self.sink(&client) | ||
| } else { | ||
| self.float(client, r)?; | ||
| None | ||
| }) |
There was a problem hiding this comment.
Can this be bound to a variable and returned as Ok(rect) rather wrapping the whole if statement
…g_state; testcase: floating_client_status tests is_floating;
|
I tried to split |
sminez
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve issue #306
Adds: