Skip to content

Commit

Permalink
chore: re-enable govulncheck
Browse files Browse the repository at this point in the history
Upstream issue was fixed: golang/go#64112 (comment)

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
  • Loading branch information
smira committed Jan 25, 2024
1 parent 8dde046 commit 07095cd
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
5 changes: 0 additions & 5 deletions .kres.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,3 @@ spec:
kind: service.CodeCov
spec:
targetThreshold: 25 # the actual coverage is much higher and reported from the integration test
---
# see https://github.com/golang/go/issues/64112
kind: golang.GoVulnCheck
spec:
disabled: true
7 changes: 6 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
#
# Generated on 2024-01-23T11:18:17Z by kres latest.
# Generated on 2024-01-25T16:14:09Z by kres latest.

ARG TOOLCHAIN

Expand Down Expand Up @@ -87,6 +87,11 @@ COPY .golangci.yml .
ENV GOGC 50
RUN --mount=type=cache,target=/root/.cache/go-build --mount=type=cache,target=/root/.cache/golangci-lint --mount=type=cache,target=/go/pkg golangci-lint run --config .golangci.yml

# runs govulncheck
FROM base AS lint-govulncheck
WORKDIR /src
RUN --mount=type=cache,target=/root/.cache/go-build --mount=type=cache,target=/go/pkg govulncheck ./...

# runs unit-tests with race detector
FROM base AS unit-tests-race
WORKDIR /src
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
#
# Generated on 2024-01-23T11:18:17Z by kres latest.
# Generated on 2024-01-25T16:14:09Z by kres latest.

# common variables

Expand Down Expand Up @@ -163,7 +163,8 @@ fmt: ## Formats the source code
go install mvdan.cc/gofumpt@$(GOFUMPT_VERSION) && \
gofumpt -w ."

lint-govulncheck: ## Disabled govulncheck linter.
lint-govulncheck: ## Runs govulncheck linter.
@$(MAKE) target-$@

lint-goimports: ## Runs goimports linter.
@$(MAKE) target-$@
Expand Down

0 comments on commit 07095cd

Please sign in to comment.