Allowed reading of scan descriptions from Raw Files #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 171 171
Lines 28862 28870 +8
Branches 2862 2863 +1
=======================================
+ Hits 21474 21482 +8
Misses 6902 6902
Partials 486 486
|
nbollis
requested review from
trishorts,
Alexander-Sol,
YulingDai,
elaboy and
kyp4
trishorts
approved these changes
Oct 30, 2023
Alexander-Sol
approved these changes
Nov 1, 2023
elaboy
approved these changes
Nov 21, 2023
Alexander-Sol
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan description was a field that was not read into the MsDataScan object, it now is read in when present in raw files