Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro optimizations #813

Closed
wants to merge 4 commits into from

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Dec 11, 2024

PR Classification

Code optimization and performance improvements.

PR Summary

This pull request focuses on optimizing code performance and improving readability.

  • ClassicDeconvolutionAlgorithm.cs: Initialized lists with estimated sizes and optimized charge state handling.
  • PpmTolerance.cs: Introduced _factor for precomputed calculations and simplified methods.
  • BioPolymerWithSetModsExtensions.cs: Initialized StringBuilder with estimated capacity.
  • DigestionProduct.cs: Refactored modification calculations and simplified conditional logic.
  • ModificationLocalization.cs: Optimized ModFits and MotifMatches methods for better performance.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.21%. Comparing base (6411360) to head (532aaa7).

Files with missing lines Patch % Lines
...ib/Omics/Modifications/ModificationLocalization.cs 92.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   77.21%   77.21%           
=======================================
  Files         218      218           
  Lines       32966    32972    +6     
  Branches     3413     3418    +5     
=======================================
+ Hits        25455    25460    +5     
  Misses       6944     6944           
- Partials      567      568    +1     
Files with missing lines Coverage Δ
...lution/Algorithms/ClassicDeconvolutionAlgorithm.cs 96.95% <100.00%> (+0.03%) ⬆️
mzLib/MzLibUtil/PpmTolerance.cs 100.00% <100.00%> (ø)
mzLib/Omics/BioPolymerWithSetModsExtensions.cs 95.34% <100.00%> (ø)
mzLib/Omics/Digestion/DigestionProduct.cs 95.65% <100.00%> (+0.87%) ⬆️
...ib/Omics/Modifications/ModificationLocalization.cs 93.02% <92.59%> (-4.48%) ⬇️

@nbollis nbollis closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant