Undo Rounding #831
Merged
Undo Rounding #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
=======================================
Coverage 77.76% 77.76%
=======================================
Files 230 230
Lines 34166 34166
Branches 3540 3540
=======================================
Hits 26569 26569
Misses 6991 6991
Partials 606 606
|
nbollis
approved these changes
Jan 30, 2025
trishorts
requested review from
trishorts,
pcruzparri,
zhuoxinshi and
RayMSMS
trishorts
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #821.
Rounding mz values was an attempt to resolve an issue where calibration within metamorpheus returned variable results. Rounding did not, in fact, resolve that issue.