-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue to Improve Testing for GlassBR #70
Comments
Note: interp.py in Python subfolder defines
was simplified to
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Note to self for cleanup of infrastructure (WIP)
, which is related to the implementation
|
This comment has been minimized.
This comment has been minimized.
@niazim3, please feel free to improve the test code and documentation as you see fit. The eventual goal is to write something that you wish you had found when you first looked at the test code. 😄 In writing the new test documentation and test code, please change the current names to more meaningful names. testTable1 and testTable2 do not tell us anything. It is also good if the test case summaries do not needlessly repeat information. If many test cases share inputs, then we should only summarize these inputs once, and simply distinguish each test case by how it is different from the others. I made a similar comment for: Perhaps you and @elwazana should discuss the best way to document the test cases? Our goal is something that makes sense to humans, but that we can also imagine generating from the knowledge in Drasil. |
As of commit 01e1337,
For now, just going to point out that these numbers are the first caseStudies/CaseStudies/glass/Implementations/Python/Test/testReadTable.py Lines 40 to 45 in 01e1337
read_x_array('TSD.txt', len(w_array)) call produced the following list (partial list of the approximately 500 lines produced): |
Not sure why these weren't coming up earlier, but
. |
Yes, I think we should close this issue. Part of my motivation for wanting to redesign GlassBR was the confusion around testing in the previous version. I think things should fit together better with the redesign. |
This issue is a continuation of JacquesCarette/Drasil#347.
testInterp.py
Broken as Implementation module has no attributes
find_bound
andinterp
andx1
is not defined (mentioned in comments of this commit).testReadTable.py
Broken, as mentioned in the comments of this commit.
testMainFun.py
Has 1 failure upon running
make test
:Please update TestingPythonGlassBR.tex and TestingPythonGlassBR.pdf as deemed necessary.
The text was updated successfully, but these errors were encountered: