m

smithy-lang · Oct 8, 2024 · 458a5b9 · 458a5b9
1 parent 2e68fdc
commit 458a5b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/...olymorph/smithypython/localservice/extensions/DirectedDafnyPythonLocalServiceCodegen.java b/...olymorph/smithypython/localservice/extensions/DirectedDafnyPythonLocalServiceCodegen.java
@@ -505,6 +505,8 @@ protected void generateOrphanedShapesForService(
  shapeToGenerate.asUnionShape().get(),
  directive.context()
  );
+ } else if (shapeToGenerate.isStringShape()) {
+ // Orphaned strings are apparently not generated for .NET/Java
  } else {
  // Add more as needed...
  throw new ClassCastException(

diff --git a/codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/utils/ModelUtils.java b/codegen/smithy-dafny-codegen/src/main/java/software/amazon/polymorph/utils/ModelUtils.java
@@ -734,6 +734,9 @@ public static List<Shape> getTopologicallyOrderedOrphanedShapesForService(
 
  TopologicalIndex topologicalIndex = TopologicalIndex.of(model);
 
+ // Get orphaned shapes under the following conditions:
+ // 1. In the same namespace as the service. (Should only generate shapes in this service.)
+ // 2. Not a member shape. (Member shapes don't have their own shapes generated for them.)
  for (Shape shape : topologicalIndex.getOrderedShapes()) {
  if (orphanedShapes.contains(shape)
  && shape.getId().getNamespace().equals(serviceShape.getId().getNamespace())