fix(Go): fix missing imports (#739)

* auto commit * auto commit * auto commit --------- Co-authored-by: Shubham Chaturvedi <anotherosscontributor@gmail.com>
smithy-lang · Dec 9, 2024 · 8a7d9fe · 8a7d9fe
1 parent caef779
commit 8a7d9fe
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/...tware/amazon/polymorph/smithygo/localservice/DafnyLocalServiceTypeConversionProtocol.java b/...tware/amazon/polymorph/smithygo/localservice/DafnyLocalServiceTypeConversionProtocol.java
@@ -1216,6 +1216,18 @@ private void handleDepErrorSerializer(
             )
         );
       } else {
+        w.addImportFromModule(
+          SmithyNameResolver.getGoModuleNameForSmithyNamespace(
+            depShape.toShapeId().getNamespace()
+          ),
+          SmithyNameResolver.smithyTypesNamespace(depShape)
+        );
+        w.addImportFromModule(
+          SmithyNameResolver.getGoModuleNameForSmithyNamespace(
+            depShape.toShapeId().getNamespace()
+          ),
+          SmithyNameResolver.shapeNamespace(depShape)
+        );
         w.write(
           """
           case $L.$LBaseException:
@@ -1487,6 +1499,12 @@ func Error_FromDafny(err $L.Error)(error) {
                 final var depService = context
                   .model()
                   .expectShape(dep, ServiceShape.class);
+                writer.addImportFromModule(
+                  SmithyNameResolver.getGoModuleNameForSmithyNamespace(
+                    depService.toShapeId().getNamespace()
+                  ),
+                  SmithyNameResolver.shapeNamespace(depService)
+                );
                 w.write(
                   """
                   if err.Is_$L() {

diff --git a/...ftware/amazon/polymorph/smithygo/localservice/shapevisitor/DafnyToSmithyShapeVisitor.java b/...ftware/amazon/polymorph/smithygo/localservice/shapevisitor/DafnyToSmithyShapeVisitor.java
@@ -231,6 +231,12 @@ private String referencedResourceShape(final Shape resourceOrService) {
         ),
         SmithyNameResolver.shapeNamespace(resourceShape)
       );
+      writer.addImportFromModule(
+        SmithyNameResolver.getGoModuleNameForSmithyNamespace(
+          resourceOrService.toShapeId().getNamespace()
+        ),
+        SmithyNameResolver.smithyTypesNamespace(resourceShape)
+      );
       namespace =
         SmithyNameResolver.shapeNamespace(resourceOrService).concat(".");
     }
@@ -582,6 +588,19 @@ public String stringShape(final StringShape shape) {
       );
     }
     if (shape.hasTrait(EnumTrait.class)) {
+      if (
+        !shape
+          .toShapeId()
+          .getNamespace()
+          .equals(context.settings().getService().getNamespace())
+      ) {
+        writer.addImportFromModule(
+          SmithyNameResolver.getGoModuleNameForSmithyNamespace(
+            shape.toShapeId().getNamespace()
+          ),
+          DafnyNameResolver.dafnyTypesNamespace(shape)
+        );
+      }
       if (this.isOptional) {
         return """
           return func () *%s.%s {