Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dafny-library-codgen SmithyBuildPlugin #153

Open
robin-aws opened this issue Mar 1, 2023 · 3 comments
Open

Add dafny-library-codgen SmithyBuildPlugin #153

robin-aws opened this issue Mar 1, 2023 · 3 comments
Labels
general-dafny-use New functionality or clean up for broader use of this repo

Comments

@robin-aws
Copy link
Contributor

robin-aws commented Mar 1, 2023 •
edited
Loading

This would live inside the same smithy-dafny-codegen library specified in #151, but would be a separate plugin from dafny-codegen.

NOT for https://github.com/awslabs/polymorph/milestone/1, more for future packaging of the existing functionality in this repo for using Smithy as an FFI between Dafny and other languages, in a more smithy-<language> idiomatic style like the dafny-client-codegen plugin.

Needs more design elaboration.
@robin-aws robin-aws changed the title Add dafny-library-codgen Gradle plugin Add dafny-library-codgen SmithyBuildPlugin Mar 1, 2023
@robin-aws robin-aws added the general-dafny-use New functionality or clean up for broader use of this repo label Mar 1, 2023
@robin-aws
Copy link
Contributor Author

Could also consider dafny-library-sdk-codegen, to complement the existing <lang>-ssdk-codegen ID from other smithy-<lang> projects (where SSDK == Server SDK: https://smithy.io/2.0/ts-ssdk/introduction.html?highlight=ssdk).

@robin-aws
Copy link
Contributor Author

Relevant Smithy documentation: https://smithy.io/2.0/guides/building-codegen/configuring-the-generator.html#how-to-name-codegen-plugins

Ideally we would get "library" added there too.

@robin-aws
Copy link
Contributor Author

Should depend on #161

robin-aws added a commit that referenced this issue Apr 19, 2024
@robin-aws @josecorella
chore: Update for /pull/189 (#153)
d061ff4 
Account for the changes in #189, mainly depending on the classpath for AWS traits instead of local copies, and using the aws.api#service$sdkId value to name Dafny clients when present instead of the shape name.

Regenerated all the Smithy-generated code and reviewed the diff, although I think there have been other smithy-dafny changes besides mine that haven't been applied, specifically around component ordering.

Also renamed KeyManagementService back to TrentService as it was in the original Smithy model, now that smithy-dafny uses the sdkId instead.

Co-authored-by: José Corella <39066999+josecorella@users.noreply.github.com>
robin-aws pushed a commit that referenced this issue Apr 19, 2024
@josecorella
chore: remove netstandard2.0 support (#153)
2a95bcf 
* Revert "chore: retrieve netstandard2.0 signed dll to publish (#149)"

This reverts commit 829fe47.

* Revert "feat(NET): support netstandard2.0 (#132)"

This reverts commit 98a16a8.
@robin-aws robin-aws mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
general-dafny-use New functionality or clean up for broader use of this repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robin-aws