-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton codegen layout #177
Conversation
Let's just add this to the end of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great!
...fny-codegen/src/main/java/software/amazon/smithy/dafny/codegen/DafnyClientCodegenPlugin.java
Show resolved
Hide resolved
|
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just want to let another existing code owner approve too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect READMEs for smithy-dafny-codegen-test
& smithy-dafny-codegen
,
even just stubbed ones.
Or entries in the codegen/README.md
for those directories.
But, as the repo matures, maybe the purpose of those directories will become more apperent.
...fny-codegen/src/main/java/software/amazon/smithy/dafny/codegen/DafnyClientCodegenPlugin.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: seebees <ryanemer@amazon.com>
Issue #, if available: Part of #151
Description of changes: Adds a skeleton of the Smithy plugin codegen layout as described in https://smithy.io/2.0/guides/building-codegen/creating-codegen-repo.html#codegen-repo-layout
Since there are no meaningful tests yet, I haven't added any CI workflows to this PR. But running
./gradlew :smithy-dafny-codegen:test
does run the tests fromDafnyClientCodegenPluginTest.java
as expected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.