Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SimpleBoolean TestModel for Rust #344

Merged
merged 5 commits into from
May 2, 2024

Conversation

andrewbanchich
Copy link
Collaborator

Description of changes:

adds Rust code expected to be generated by Dafny -> Rust for SimpleBoolean

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewbanchich andrewbanchich requested a review from a team as a code owner April 22, 2024 15:10
@andrewbanchich andrewbanchich marked this pull request as draft April 22, 2024 15:17
@andrewbanchich andrewbanchich force-pushed the andrewbanchich/simpleboolean branch 2 times, most recently from a16c458 to fe0bdc7 Compare April 30, 2024 14:10
@andrewbanchich andrewbanchich marked this pull request as ready for review April 30, 2024 14:14
@robin-aws
Copy link
Contributor

Having a look now, but one important thing to fix right away: make sure you uncomment this line so that the tests are actually run in CI: https://github.com/smithy-lang/smithy-dafny/blob/main-1.x/.github/workflows/test_models_rust_tests.yml#L36

@andrewbanchich andrewbanchich force-pushed the andrewbanchich/simpleboolean branch 3 times, most recently from f4255ff to f1951af Compare May 1, 2024 17:31
Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of minor fixups.

@andrewbanchich andrewbanchich force-pushed the andrewbanchich/simpleboolean branch 4 times, most recently from 7c7e5f7 to 650337b Compare May 2, 2024 19:34
@robin-aws robin-aws merged commit 17a810d into main-1.x May 2, 2024
131 checks passed
@robin-aws robin-aws deleted the andrewbanchich/simpleboolean branch May 2, 2024 21:40
@andrewbanchich andrewbanchich changed the title feat: add SimpleBoolean for Rust feat: add SimpleBoolean TestModel for Rust May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants