Improve name conflicts resolving #902
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR is aimed to fix two problems:
Current implementation added
type
into thereserved-words.txt
and this approach is too broad.We want to only resolve the conflict when the name
type
is used, for example,Union
orEnum
.The original approach to resolve implicit name conflict tried to add all symbols generated under the same package into each file's
symbolTable
which caused some unnecessary name conflicts.We only want to resolve the conflicts when those auto-imported
java.lang.*
classes likeillegalArgumentException
are used and one class with the same name defined under the same namespace.For example, the
ShapeSerializer
is used with a fully qualified name even though it is imported. This happened because one shape also calledShapeSerializer
was generated under the same namespace and added into this file's symbol table.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.