Skip to content

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Dec 20, 2024

  • Creates a new annotation class @IgnoreNative which is a no-op on JVM and a typealias to kotlin.test.Ignore on Native
  • Add @IgnoreNative to all tests which are currently failing so CI "passes" and we can merge to kn-main

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner December 20, 2024 23:18
@lauzadis lauzadis changed the title kn: @Ignore failing tests kn: Ignore failing tests Jan 6, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jan 7, 2025

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
http-test-jvm.jar 61,633 58,718 2,915 4.96%
crt-util-jvm.jar 21,443 20,954 489 2.33%
runtime-core-jvm.jar 813,449 812,469 980 0.12%
aws-signing-tests-jvm.jar 456,614 456,568 46 0.01%
test-suite-jvm.jar 96,907 97,180 -273 -0.28%

@lauzadis lauzadis merged commit f5c5af0 into kn-main Jan 8, 2025
18 checks passed
@lauzadis lauzadis deleted the kn-ignore branch January 8, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants