kn: implement `SystemDefaultProvider` for Native #1231

lauzadis · 2025-01-30T17:36:22Z

Implement SystemDefaultProvider for Native
- Note: System properties are always returned null / empty.
Add a commonized test suite for Platform

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
… to Filesystem interface

…1199)

…n-platform

runtime/runtime-core/build.gradle.kts

runtime/runtime-core/common/test/aws/smithy/kotlin/runtime/util/SystemPlatformProviderTest.kt

ianbotsf · 2025-02-03T22:28:22Z

runtime/runtime-core/common/test/aws/smithy/kotlin/runtime/util/SystemPlatformProviderTest.kt

+    @Test
+    fun testOsInfo() = runTest {
+        val osInfo = PlatformProvider.System.osInfo()
+        assertNotEquals(OsFamily.Unknown, osInfo.family)
+    }


Question: Do we have tests anywhere to verify that the correct OS family is returned as opposed to verifying the incorrect one isn't?

No we don't. Since this is a common test it's not possible to assert on a specific OS family. I'll try making a target-specific source set (i.e. linuxx64) and add a test there.

Added a LinuxX64 test

runtime/runtime-core/native/src/aws/smithy/kotlin/runtime/util/PlatformNative.kt

ianbotsf · 2025-02-03T22:59:32Z

runtime/runtime-core/native/src/aws/smithy/kotlin/runtime/util/PlatformNative.kt

    actual override suspend fun readFileOrNull(path: String): ByteArray? {
-        TODO("Not yet implemented")
+        return try {


Question: The JVM impl dispatches to IO. Should this impl do the same? (similar question for writeFile)

Good suggestion, I think it should

…n-platform

0marperez · 2025-02-04T17:02:27Z

...time-core/linuxX64/test/aws/smithy/kotlin/runtime/util/SystemPlatformProviderLinuxX64Test.kt

+    }
+
+    @Test
+    fun definitelyShouldFail() = runTest {


Looks like this wasn't meant to be here?

I added it here to make sure the Linux tests are running in CI. Will be removed

0marperez · 2025-02-04T17:22:32Z

runtime/runtime-core/native/src/aws/smithy/kotlin/runtime/util/PlatformNative.kt

+
+        val family = when {
+            sysName.contains("darwin") -> {
+                if (machine.startsWith("iPhone") || machine.startsWith("iPad")) {


Question: Can we cover Apple watches & TV's as well?

Sure, I added them along with a TODO to validate it actually gets resolved correctly

github-actions · 2025-02-04T17:45:00Z

Affected Artifacts

Changed in size

Artifact	Pull Request (bytes)	Latest Release (bytes)	Delta (bytes)	Delta (percentage)
http-test-jvm.jar	61,604	58,690	2,914	4.97%
aws-signing-default-jvm.jar	53,497	51,946	1,551	2.99%
crt-util-jvm.jar	21,451	20,952	499	2.38%
runtime-core-jvm.jar	836,052	818,814	17,238	2.11%
aws-signing-tests-jvm.jar	456,687	456,627	60	0.01%
test-suite-jvm.jar	96,930	97,206	-276	-0.28%

0marperez and others added 30 commits December 16, 2024 11:30

fix: create JMESPATH flattenIfPossible functions for Lists (#1169)

a4734c7

chore: release 1.3.30

7911a94

chore: bump snapshot version to 1.3.31-SNAPSHOT

7085c8a

misc: enhance support for replayable instances of InputStream (#1197)

4575023

chore: release 1.3.31

b0a4bac

chore: bump snapshot version to 1.3.32-SNAPSHOT

80f4538

fix: CBOR protocol test assertions / blob serialization (#1198)

e9d16a9

fix: correctly serialize subset of shape's members when configured (#…

48849a1

…1199)

chore: release 1.3.32

ded3a4b

chore: bump snapshot version to 1.3.33-SNAPSHOT

d97e8ba

chore: add *-main to branch workflows (#1209)

78f17f3

chore: add .kotlin/ to .gitignore (#1208)

d06ee0a

chore: smithy version bump (#1213)

d2e7c91

chore: release 1.3.33

5a2df8f

chore: bump snapshot version to 1.3.34-SNAPSHOT

003633b

feat: add AuthTokenGenerator (#1212)

5f5ec8f

chore: release 1.3.34

3fe1b5e

chore: bump snapshot version to 1.3.35-SNAPSHOT

0bba308

misc: merge v1.4 into main (#1218)

52e4439

feat: support default checksums (#1191)

e0c25d6

chore: release 1.4.0

14e0958

chore: bump snapshot version to 1.4.1-SNAPSHOT

ed95d7b

fix: add 0.9.x aws-crt-kotlin transform (#1220)

a4ace35

fix: Ensure Host header is included when signing auth tokens (#1222)

15e5f0c

chore: release 1.4.1

447ac10

chore: bump snapshot version to 1.4.2-SNAPSHOT

0f8db44

fix: address various failing protocol tests (#1223)

8b33693

misc: re-enable kotlinWarningsAsErrors=true (#1224)

03badf9

fix: ignore hop-by-hop headers when signing requests (#1227)

9f44cdb

chore: release 1.4.2

97ac447

This comment has been minimized.

Sign in to view

Revert

cda0523

This comment has been minimized.

Sign in to view

Merge branch 'kn-main' of github.com:smithy-lang/smithy-kotlin into k…

e5c0f64

…n-platform

This comment has been minimized.

Sign in to view

Implement getAllEnvVars

d0dc45d

This comment has been minimized.

Sign in to view

lauzadis marked this pull request as ready for review February 3, 2025 21:51

lauzadis requested a review from a team as a code owner February 3, 2025 21:51

lauzadis added 2 commits February 3, 2025 16:55

Update filePathSeparator for Windows

a674cf4

e -> _

426bcfe

This comment has been minimized.

Sign in to view

ianbotsf reviewed Feb 3, 2025

View reviewed changes

lauzadis added 4 commits February 4, 2025 10:19

Merge branch 'kn-main' of github.com:smithy-lang/smithy-kotlin into k…

f4fdfe3

…n-platform

PR feedback

aa44461

Add LinuxX64 test

6bc63cf

ktlint

5e5c541

This comment has been minimized.

Sign in to view

0marperez approved these changes Feb 4, 2025

View reviewed changes

lauzadis added 3 commits February 4, 2025 12:36

Expand support of Apple platforms

e282e5c

Remove debug test

ee85998

ktlint

7dc3766

This comment has been minimized.

Sign in to view

apiDump new OsFamily

8142608

ianbotsf approved these changes Feb 4, 2025

View reviewed changes

lauzadis merged commit ae80656 into kn-main Feb 4, 2025
20 checks passed

lauzadis deleted the kn-platform branch February 4, 2025 21:39

kn: implement SystemDefaultProvider for Native #1231

kn: implement SystemDefaultProvider for Native #1231

Uh oh!

Conversation

lauzadis commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue #

Description of changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lauzadis Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 4, 2025

Affected Artifacts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kn: implement `SystemDefaultProvider` for Native #1231

kn: implement `SystemDefaultProvider` for Native #1231

lauzadis commented Jan 30, 2025 •

edited

Loading

lauzadis Feb 4, 2025 •

edited

Loading