Skip to content

Conversation

@lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Mar 1, 2025

ExecutionContext and the keys of SdkClientOption are both fully public. Let's make these convenience extension functions public too.

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Mar 1, 2025
@lauzadis lauzadis requested a review from a team as a code owner March 1, 2025 01:07
@lauzadis lauzadis changed the title misc: remove @InternalApi from SdkClientOption extension functions misc: remove @InternalApi from SdkClientOption extension functions Mar 1, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
smithy-client-jvm.jar 66,357 66,483 -126 -0.19%

@lauzadis lauzadis merged commit 4b0df67 into main Mar 3, 2025
16 checks passed
@lauzadis lauzadis deleted the remove-sdk-client-option-internal-api branch March 3, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants