misc: prepare codegen packages for internal import #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Affected ArtifactsNo artifacts changed size |
ianbotsf
approved these changes
Apr 9, 2025
| ktor-version = "3.1.1" | ||
| kaml-version = "0.55.0" | ||
| jsoup-version = "1.18.1" | ||
| jsoup-version = "1.19.1" |
Contributor
There was a problem hiding this comment.
Question: Why was this change necessary?
Contributor
Author
There was a problem hiding this comment.
It wasn't necessary but internally we have a choice of 1.18.3 or 1.19.1 (which is the latest version). I chose to upgrade to the latest
Contributor
Author
There was a problem hiding this comment.
Ideally we would just remove this dependency, I took a quick attempt but it's deeply entangled in our documentation preprocessor. There's no alternative API offered by Kotlin / another one of our existing dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.