Skip to content

misc: add lineSeparator to Filesystem #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

misc: add lineSeparator to Filesystem #1267

merged 5 commits into from
Apr 14, 2025

Conversation

lauzadis
Copy link
Contributor

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner April 10, 2025 01:56
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Apr 10, 2025

This comment has been minimized.

1 similar comment

This comment has been minimized.

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line separators are not filesystem-specific, they're OS-specific. This shouldn't be a property of Filesystem.

This comment has been minimized.

This comment has been minimized.

Copy link

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
runtime-core-jvm.jar 830,220 829,386 834 0.10%

@lauzadis lauzadis requested a review from ianbotsf April 14, 2025 21:20
@lauzadis lauzadis merged commit 44d19cd into main Apr 14, 2025
16 checks passed
@lauzadis lauzadis deleted the misc-lineSeparator branch April 14, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants