Service sdk testing #1330

luigi617 · 2025-07-16T21:05:30Z

Serializer will serialize only the data and not create a HttpRequest.
Change JAVA version to 17
Enable CIO, Jetty-jakarta engine (and Netty which was already supported)
Accept type checker
Creation of service generator tests
Unit tests will be refined in the next PR

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…hy-kotlin into server-sdk-main # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…n into service-sdk-serde # Conflicts: # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/RuntimeTypes.kt # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/service/ServiceStubGenerator.kt

…ntime rather than compile

…ice-sdk-testing # Conflicts: # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/CodegenVisitor.kt # codegen/smithy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt

…e-sdk-testing

...otlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/KotlinDependency.kt

...hy-kotlin-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/core/RuntimeTypes.kt

...main/kotlin/software/amazon/smithy/kotlin/codegen/rendering/serde/CborSerializerGenerator.kt

...n-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/service/KtorStubGenerator.kt

ianbotsf · 2025-07-22T16:50:18Z

tests/codegen/service-codegen-tests/src/main/kotlin/com/test/DefaultServiceGeneratorTest.kt

+import java.nio.file.Path
+import java.nio.file.Paths
+
+fun main() {


Question: Our test projects don't normally need main() methods. Why couldn't this work be done in a @Before method or even manually written and checked into the repository?

This function is used to generate the service. In gradle.build.kts, you can see that the test depends on runServiceGenerator which will call this funciton. The reason why not having this in @Before method is that I want to separate the file for generating service and testing it. I don't understand what you meant by "manually written and checked into the repository".

tests/codegen/service-codegen-tests/src/test/kotlin/com/test/ServiceGeneratorTest.kt

0marperez

Overall looks good! Just had some small suggestions, nit's and questions but the Java 17 changes would cause us to regress on the behavior introduced by #1297. That's the only blocking thing for me.

codegen/smithy-kotlin-codegen-testutils/build.gradle.kts

...lin/software/amazon/smithy/kotlin/codegen/rendering/protocol/HttpBindingProtocolGenerator.kt

...n-codegen/src/main/kotlin/software/amazon/smithy/kotlin/codegen/service/KtorStubGenerator.kt

tests/codegen/service-codegen-tests/model/service-generator-test.smithy

tests/codegen/service-codegen-tests/src/test/kotlin/com/test/ServiceGeneratorTest.kt

luigi added 30 commits June 24, 2025 15:17

service init, code to separate client and service

a5fbb3d

server can be ran

74efe84

application in build.gradle.kts

172cc97

detele non-finished code

e9007b1

ktlintformat

03c15d0

change style

7c6ca67

ktlintformat

3a9ec4d

add abstraction for service

7fb8705

minor fix

859c02b

minor fix

7d5b92e

cbor serde

1455933

fix

40d4af8

formatting

3db1971

comment

219c66f

fix

d0b7d11

fix

4de4c84

generate routing based on smithy file

f9fb095

ktlint format

313b758

service framework abstraction

8870ca4

ktlint foramt

c108529

logging

344512b

ktlint format

304550a

add ContentTypeGuard

bdb9101

ktlint

40f69b0

fix content type guard

23590fe

pull from server-sdk-main

3b750b2

ktlint

9b14ed7

move some parameters, e.g. engine, port, log level to be chosen in ru…

68b985e

…ntime rather than compile

fix

b8fd8ed