chore: upgrade ktlint #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ianbotsf
approved these changes
Oct 27, 2021
Comment on lines
+85
to
+89
| val ktlint by configurations.creating { | ||
| attributes { | ||
| attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling.EXTERNAL)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Question: As near as I can tell from the Bundling documentation, EXTERNAL is the default. Why was this necessary to specify?
There was a problem hiding this comment.
They added a variant and gradle couldn't auto detect the correct configuration.
There was a problem hiding this comment.
kggilmer
approved these changes
Oct 28, 2021
aajtodd
added a commit
that referenced
this pull request
Mar 15, 2022
aajtodd
added a commit
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Upgrade ktlint. This is to stay in sync with
aws-sdk-kotlinwhich was forced to upgrade in awslabs/aws-sdk-kotlin#372By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.