Fix path serialization #113
Conversation
| * shape. This may use native types or invoke complex type serializers to | ||
| * manipulate the dataSource into the proper input content. | ||
| */ | ||
| private static class HttpMemberSerVisitor extends ShapeVisitor.Default<String> { |
There was a problem hiding this comment.
I moved all of this to a visitor from the hodgepodge methods above. The move to the visitor was a single commit, and behavioral changes are in other commits.
| RFC3339 = "%Y-%m-%dT%H:%M:%SZ" | ||
| # Same as RFC3339, but with microsecond precision. | ||
| RFC3339_MICRO = "%Y-%m-%dT%H:%M:%S.%fZ" |
There was a problem hiding this comment.
These were pulled from botocore, but given more specific names.
JordonPhillips
force-pushed
the
fix-path-ser
branch
2 times, most recently
from
24be60e to
6482d73
Compare
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
One question, apologies I didn't catch it during the last review. Once that's answered though, the rest of this looks good to me.
| if context.transport_request.url.path: | ||
| endpoint.url.path += context.transport_request.url.path | ||
| endpoint.url.query = context.transport_request.url.query | ||
| endpoint.url.host = context.transport_request.url.host + endpoint.url.host |
There was a problem hiding this comment.
I'm not sure I understand what's happening here. Why are we concatenating two hosts and what's the expected outcome? Is context.transport_request.url.host a prefix in this case?
There was a problem hiding this comment.
Yeah, the hostLabel trait allows for setting an endpoint prefix, so this is just accounting for that.
JordonPhillips
force-pushed
the
fix-path-ser
branch
2 times, most recently
from
f6e9618 to
485ae72
Compare
This updates the protocol tests to parse any timestamps inside the generator and output a constructor rather than delegating the parsing to python. This was already being done in the structure generator for default values, so this shares that effort.
This updates unix timestamp serialization to omit fractional seconds when that fraction is 0.
JordonPhillips
force-pushed
the
fix-path-ser
branch
from
485ae72 to
f5f9d2d
Compare
|
@jonemo I had to rebase, but all the changes I've made in response to your comments are in the latest commit. |
...ithy-python-codegen/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
Outdated
Show resolved
Hide resolved
...thon-codegen/src/main/java/software/amazon/smithy/python/codegen/SmithyPythonDependency.java
Outdated
Show resolved
Hide resolved
3 participants
This fixes a number of bugs uncovered by protocol tests in path serialization.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.