-
Notifications
You must be signed in to change notification settings - Fork 25
Support query serialization #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5cc0ac1 to
1c4dbb0
Compare
1c4dbb0 to
e8e21a4
Compare
| writer.pushState(new SerializeQuerySection(operation)); | ||
| writer.write("query_params: list[tuple[str, str | None]] = []"); | ||
| // TODO: implement query serialization | ||
| writer.writeInline("query_params: list[tuple[str, str | None]] = ["); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I understand how we intend this to work. If I want mylonginfovalue1234567890 appended to the end of my URI as the only part of a query string, it would be something like:
query_params = [('mylonginfovalue1234567890', None)]
uri = build_uri(query_params=query_params, **kwargs)
>>> https://example.com/?mylonginfovalue1234567890There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
fe5ea0e
Note: this depends on #126. The first commit was pulled from that.Sample output:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.