integration tests pytest fixture for running local http server #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not asking for a thorough review. I only want second (and third and fourth) opinion on whether to keep working on this or to cut my losses and scrap it.
Currently, we make requests to public websites like
https://aws.amazon.com
as part of our integration tests. While writing integration tests for HTTP client implementations, I figured: Why not instead run a server locally as a pytest fixture? Seems easy enough with Python'shttp.server.SimpleHTTPRequestHandler
. Several rabbit hole explorations later I suddenly find myself passing ctyped locks into processes managed withmultiprocessing
and working around bugs in type annotations of the more obscure corners of Python's stdlib.Benefits of having a local server in a fixture:
Downsides of having a local server in a fixture:
module
level amortizes this over many tests.)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.