Skip to content

Commit

Permalink
Fix job trigger. Clarify that short SHAs won't work. (#2278)
Browse files Browse the repository at this point in the history
  • Loading branch information
LukeMathWalker authored Feb 2, 2023
1 parent bf3575f commit 2a913a7
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ on:
workflow_dispatch:
inputs:
commit_sha:
description: The SHA of the git commit that you want to release (e.g. b2318b0)
description: |
The SHA of the git commit that you want to release.
You must use the non-abbreviated SHA (e.g. b2318b0 won't work!).
required: true
type: string
semantic_version:
Expand Down Expand Up @@ -69,6 +71,13 @@ jobs:
name: Get or create a release branch
needs:
- release-ci
- acquire-base-image
# We need `always` here otherwise this job won't run if the previous job has been skipped
# See https://samanpavel.medium.com/github-actions-conditional-job-execution-e6aa363d2867
if: |
always() &&
needs.acquire-base-image.result == 'success' &&
(needs.release-ci.result == 'success' || needs.release-ci.result == 'skipped')
runs-on: ubuntu-latest
outputs:
release_branch: ${{ steps.branch-push.outputs.release_branch }}
Expand Down Expand Up @@ -121,7 +130,7 @@ jobs:
echo "Pushing upgraded gradle.properties commit..."
git push origin
fi
echo "commit_sha=$(git rev-parse --short HEAD)" > $GITHUB_OUTPUT
echo "commit_sha=$(git rev-parse HEAD)" > $GITHUB_OUTPUT
release:
name: Release
Expand Down

0 comments on commit 2a913a7

Please sign in to comment.