Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose MSRV to codegen #2048

Closed
rcoh opened this issue Dec 1, 2022 · 1 comment · Fixed by #3841
Closed

expose MSRV to codegen #2048

rcoh opened this issue Dec 1, 2022 · 1 comment · Fixed by #3841
Labels
ops Improves our operations and release process sdk

Comments

@rcoh
Copy link
Collaborator

rcoh commented Dec 1, 2022

currently, gradle has an MSRV setting but we don't have access to this during codegen
@jdisanti
Copy link
Collaborator

jdisanti commented Apr 5, 2024

What use-case do we have for needing MSRV during codegen?

@jdisanti jdisanti added sdk ops Improves our operations and release process labels Apr 5, 2024
@drganjoo drganjoo mentioned this issue Sep 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@drganjoo
Set MSRV in rust-toolchain.toml using the gradle.property (#3841)
684c15f 
The `rust-toolchain.toml` file for tests now uses the `rust.msrv` value
from the `gradle.properties` file.

This PR also fixes an issue where the `rust-toolchain.toml` file was not
created in the overridden test directory when `overrideTestDir` was set.
This caused the installed compiler version to be used, resulting in
errors with the latest compiler and preventing the use of
`overrideTestDir`.

Closes: #2048

---------

Co-authored-by: Fahad Zubair <fahadzub@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ops Improves our operations and release process sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set MSRV in rust-toolchain.toml using the gradle.property smithy-lang/smithy-rs
2 participants
@jdisanti @rcoh