Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryClassifiers do not appear to be ordered properly #3322

Closed
rcoh opened this issue Dec 14, 2023 · 1 comment
Closed

RetryClassifiers do not appear to be ordered properly #3322

rcoh opened this issue Dec 14, 2023 · 1 comment
Assignees
@Velfi
Labels
bug Something isn't working

Comments

@rcoh
Copy link
Collaborator

rcoh commented Dec 14, 2023

RetryClassifiers are intended to be ordered by priority, however, they do not appear to be ordered at any point when they are actually evaluated.
@rcoh rcoh added the bug Something isn't working label Dec 14, 2023
@Velfi Velfi mentioned this issue Feb 6, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
@Velfi @jdisanti
Implement and test retry classifier sorting (#3392)
df1103d 
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->
#3322

## Description
<!--- Describe your changes in detail -->
I gave classifiers priorities but never actually sorted them. This PR
fixes that.

## Testing
<!--- Please describe in detail how you tested your changes -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
I wrote a test

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: John DiSanti <jdisanti@amazon.com>
@Velfi
Copy link
Contributor

Velfi commented Feb 26, 2024 •
edited
Loading

This was released February 15, 2024

@Velfi Velfi closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velfi Velfi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcoh @Velfi