generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 224
Closed
Labels
bugSomething isn't workingSomething isn't workingclientgood first issueGood for newcomersGood for newcomerssdk-ga
Milestone
Description
The aws-sigv4 crate currently implements the Display trait for formatting the canonical request, and since it's using ToString to do the actual formatting, it will panic if there's any error during that formatting.
In #710, we fixed a bug where header values that contained non-ASCII characters would cause a panic, but the problem was just punted a little bit since now it can panic if there's invalid UTF-8 in the header value.
Options we should evaluate and choose from:
- Refactor
CanonicalRequestto have a fallible format function instead of implementingDisplay, and bubble the error up. - Refactor
CanonicalRequestto have an infallible format function, but produce bytes instead of a string, and put the header value's bytes directly into the formatted canonical request.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingclientgood first issueGood for newcomersGood for newcomerssdk-ga