Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Server] Reimplement httpLabel trait deserializer without regexes #938

Closed
crisidev opened this issue Dec 7, 2021 · 0 comments · Fixed by #996
Closed

[Server] Reimplement httpLabel trait deserializer without regexes #938

crisidev opened this issue Dec 7, 2021 · 0 comments · Fixed by #996
Labels
enhancement New feature or request ergonomics server Rust server SDK

Comments

@crisidev
Copy link
Contributor

crisidev commented Dec 7, 2021

Currently we use regexes to deserialize httpLabel traits: https://github.com/awslabs/smithy-rs/blob/6e423810ab8ed6db32a306df5f2189a7d72f668c/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/protocols/ServerHttpProtocolGenerator.kt#L572

We should use the same parsing mechanism we will use for #937.
@crisidev crisidev added enhancement New feature or request ergonomics server Rust server SDK labels Dec 7, 2021
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Dec 20, 2021
@82marbag
Implement httpLabel with nom
85caf29 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Dec 20, 2021
@82marbag
Implement httpLabel with nom
b268944 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
@82marbag 82marbag mentioned this issue Dec 20, 2021
Merged
2 tasks
@crisidev crisidev linked a pull request Dec 20, 2021 that will close this issue
Implement httpLabel with nom #996
Merged
2 tasks
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Dec 20, 2021
@82marbag
Implement httpLabel with nom
e6eb95a 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Dec 23, 2021
@82marbag
Implement httpLabel with nom
a430987 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Jan 3, 2022
@82marbag
Implement httpLabel with nom
f14dfd0 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Jan 4, 2022
@82marbag
Implement httpLabel with nom
1120c83 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Jan 4, 2022
@82marbag
Implement httpLabel with nom
5bec90c 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
82marbag added a commit to 82marbag/smithy-rs that referenced this issue Jan 5, 2022
@82marbag
Implement httpLabel with nom
29cbd04 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: smithy-lang#938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>
david-perez added a commit that referenced this issue Jan 5, 2022
@82marbag @david-perez
Implement httpLabel with nom (#996)
e935fbc 
Move to `nom` to implement httpLabel instead of using regexes.

Issue: #938

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.com>

Co-authored-by: david-perez <d@vidp.dev>
@david-perez david-perez mentioned this issue Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ergonomics server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement httpLabel with nom 82marbag/smithy-rs
1 participant
@crisidev