Revamp errors in aws-smithy-checksums
#1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Oct 14, 2022
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
cab8db6
to
61c63d0
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
6e3e165
to
1b90d4c
Compare
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
61c63d0
to
5fe1e7d
Compare
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
1b90d4c
to
ea102d4
Compare
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
5fe1e7d
to
6338f4c
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
ea102d4
to
b3a2b6c
Compare
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
6338f4c
to
e053f34
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
b3a2b6c
to
bd16b5d
Compare
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
e053f34
to
55c1535
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
cd90022
to
a15055e
Compare
hlbarber
approved these changes
Nov 10, 2022
| import software.amazon.smithy.rust.codegen.core.rustlang.rustBlock | ||
| import software.amazon.smithy.rust.codegen.core.smithy.RuntimeType | ||
|
|
||
| internal fun unhandledError(): RuntimeType = RuntimeType.forInlineFun("Unhandled", RustModule.Error) { |
There was a problem hiding this comment.
It might be more readable to do this in one rustTemplate rather than chopping it up?
There was a problem hiding this comment.
Good call. Not sure why I didn't think of that 😅
| @@ -397,7 +376,7 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[should_panic = "called `Result::unwrap()` on an `Err` value: UnknownChecksumAlgorithm(\"some invalid checksum algorithm\")"] | |||
| #[should_panic = "called `Result::unwrap()` on an `Err` value: UnknownChecksumAlgorithmError { checksum_algorithm: \"some invalid checksum algorithm\" }"] | |||
There was a problem hiding this comment.
The reason we're should_panic here rather than asserting on the error type is because we don't want to derive PartialEq on the error?
There was a problem hiding this comment.
Would it be better to match on the error and then assert on the checksum_algorithm?
jdisanti
force-pushed
the
jdisanti-unhandled-error-newtype
branch
from
a15055e
to
00fa06a
Compare
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
55c1535
to
104d2aa
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-errors-smithy-checksums
branch
from
104d2aa
to
6271b8c
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR revamps errors in
aws-smithy-checksumsto adhere to RFC-0022: Error Context and Compatibility.This PR is part of a series that will fully implement the RFC, tracked in #1926.
Changelog entries added in #1951.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.