Revamp errors for aws-sigv4
#1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-errors-aws-sigv4
branch
from
88580e1
to
5c0f606
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Nov 3, 2022
Comment on lines
+22
to
+38
| impl fmt::Display for SigningError { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self.kind { | ||
| SigningErrorKind::FailedToCreateCanonicalRequest { .. } => { | ||
| write!(f, "failed to create canonical request") | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Error for SigningError { | ||
| fn source(&self) -> Option<&(dyn Error + 'static)> { | ||
| match &self.kind { | ||
| SigningErrorKind::FailedToCreateCanonicalRequest { source } => Some(source), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe this follows #1345?
There was a problem hiding this comment.
Yes. The source doesn't get written in the Display impl so that it's not duplicated for error reporters that follow the source chain.
| use std::str; | ||
|
|
||
| /// Signing error type | ||
| pub type Error = Box<dyn StdError + Send + Sync + 'static>; |
| @@ -121,8 +121,6 @@ impl fmt::Debug for SigV4Signer { | |||
| } | |||
| } | |||
|
|
|||
| pub type SigningError = Box<dyn Error + Send + Sync>; | |||
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR revamps errors in
aws-sigv4to adhere to RFC-0022: Error Context and Compatibility.This PR is part of a series that will fully implement the RFC, tracked in #1926.
Changelog entries added in #1951.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.