Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of repeated headers in aws request canonicalization #2261

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Fix handling of repeated headers in aws request canonicalization #2261

merged 7 commits into from
Feb 3, 2023

Commits on Jan 28, 2023

  1. Fix handling of repeated headers in aws request canonicalization 

    See spec in
https://docs.aws.amazon.com/general/latest/gr/create-signed-request.html#create-canonical-request

Previously, repeated headers would appear twice on separate lines in the
`CanonicalHeaders` section and twice in the `SignedHeaders` section.

This PR fixes it to appear once.

This should fix issues like this one
awslabs/aws-sdk-rust#720
    @nipunn1313
    nipunn1313 committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    6c672c9 View commit details
    Browse the repository at this point in the history

  2. Update changelog.next.toml

    @nipunn1313
    nipunn1313 committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    707c1d2 View commit details
    Browse the repository at this point in the history

  3. Undo accidental extra change to test

    @nipunn1313
    nipunn1313 committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    c5988b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Target test to just the line that is repeated

    @nipunn1313
    nipunn1313 committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c740a0e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch 'main' into nipunn/repeated_header

    @jdisanti
    jdisanti authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    874d390 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Merge branch 'main' into nipunn/repeated_header

    @jdisanti
    jdisanti authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    267da5e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into nipunn/repeated_header

    @jdisanti
    jdisanti authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    445be37 View commit details
    Browse the repository at this point in the history