-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor event stream tests with {client,server}IntegrationTest
s
#2342
Merged
Merged
Changes from 12 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
58013c0
Refactor `ClientEventStreamUnmarshallerGeneratorTest` to use `clientI…
jjant 623c592
Refactor `ClientEventStreamUnmarshallerGeneratorTest` with `clientInt…
jjant 82053c2
Refactor `ClientEventStreamUnmarshallerGeneratorTest` to use generic …
jjant 5d53efc
Start refactoring `ServerEventStreamUnmarshallerGeneratorTest`
jjant c1e4bab
Make `ServerEventStreamUnmarshallerGeneratorTest` tests work
jjant fcf69bd
Uncomment other test models
jjant 573eea7
Allow unused on `parse_generic_error`
jjant 0a35b85
Rename `ServerEventStreamUnmarshallerGeneratorTest`
jjant 84f27a5
Merge branch 'main' into jjant/replace-event-stream-tests
jjant 5b08533
Make `EventStreamUnmarshallTestCases` codegenTarget-agnostic
jjant 47de13c
Refactor `ClientEventStreamMarshallerGeneratorTest`: Tests run but fail
jjant 66f7741
Refactor `ServerEventStreamMarshallerGeneratorTest`
jjant e1c5cd2
Move `.into()` calls to `conditionalBuilderInput`
jjant c1cd042
Add "context" to TODO
jjant 7a60d7c
Fix client unmarshall tests
jjant 45e762a
Fix clippy lint
jjant 1865cee
Fix more clippy lints
jjant 8223a98
Add docs for `event_stream_serde` module
jjant 5cadd33
Fix client tests
jjant 2afb915
Remove `#[allow(missing_docs)]` from event stream module
jjant 5970d74
Remove unused `EventStreamTestTools`
jjant 2bc6b3f
Add `smithy-validation-model` test dep to `codegen-client`
jjant 449d4bb
Temporarily add docs to make tests compile
jjant 6f8a5ef
Undo change in model
jjant 4b57f01
Make event stream unmarshaller tests a unit test
jjant 8c5aa82
Remove unused code
jjant 2086bd4
Merge branch 'main' into jjant/replace-event-stream-tests
jjant fefdb1a
Make `ServerEventStreamUnmarshallerGeneratorTest` a unit test
jjant fb15f43
Make `ServerEventStreamMarshallerGeneratorTest` a unit test
jjant c7887c9
Make `ServerEventStreamMarshallerGeneratorTest` pass
jjant 489a9ab
Make remaining tests non-integration tests
jjant 897c0ab
Make event stream serde module private again
jjant 2f92227
Remove unnecessary clippy allowances
jjant 8f70237
Remove clippy allowance
jjant 64d23c8
Remove docs for `event_stream_serde` module
jjant ee389ae
Remove docs for `$unmarshallerTypeName::new`
jjant eae2701
Remove more unnecessary docs
jjant 3aac2e0
Merge branch 'main' into jjant/replace-event-stream-tests
jjant 43c8040
Remove more superfluous docs
jjant 108fc18
Undo unnecessary diffs
jjant a14463a
Uncomment last test
jjant 4567ff2
Merge branch 'main' into jjant/replace-event-stream-tests
jjant e952961
Make `conditionalBuilderInput` internal
jjant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 0 additions & 90 deletions
90
...thy/rust/codegen/client/smithy/protocols/eventstream/ClientEventStreamBaseRequirements.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,7 +116,7 @@ private fun <T : AbstractCodeWriter<T>, U> T.withTemplate( | |
* This enables conditionally wrapping a block in a prefix/suffix, e.g. | ||
* | ||
* ``` | ||
* writer.withBlock("Some(", ")", conditional = symbol.isOptional()) { | ||
* writer.conditionalBlock("Some(", ")", conditional = symbol.isOptional()) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docs were wrong. |
||
* write("symbolValue") | ||
* } | ||
* ``` | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might break with @drganjoo 's PR, #2256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't 🤔