Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support to number type #2645

Merged
merged 9 commits into from
May 30, 2023

Conversation

thomas-k-cameron
Copy link
Contributor

@thomas-k-cameron thomas-k-cameron commented Apr 27, 2023

Motivation and Context

This is a child PR of #2616

The changes that this PR introduces is same as the ones that were merged to unstable-serde-support branch before.

Initially, we tried to make commit to unstable-serde-support branch and merge changes one by one in small PRs. However, in order to make it up to date with the main branch, we would need to go through a large PR of over 700 files.

Thus, I decided to create individual PRs that commits directly to main branch.

Description

  • Implements serde support to Number

Testing

  • Test checks whether the serialized/de-serialized data matches with the expected value

Checklist

NA


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This was referenced Apr 27, 2023
@thomas-k-cameron thomas-k-cameron marked this pull request as ready for review April 27, 2023 02:24
@thomas-k-cameron thomas-k-cameron requested review from a team as code owners April 27, 2023 02:24
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to take a look at this. Looks good!

rust-runtime/aws-smithy-types/src/number.rs Outdated Show resolved Hide resolved
@jdisanti jdisanti enabled auto-merge May 30, 2023 18:21
@jdisanti jdisanti added this pull request to the merge queue May 30, 2023
Merged via the queue into smithy-lang:main with commit 840221d May 30, 2023
@thomas-k-cameron thomas-k-cameron deleted the RFC30/number branch May 30, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants