Fix runtime crate versions #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
843ec3c to
abf10cb
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
abf10cb to
d088269
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
d088269 to
613a588
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
82marbag
approved these changes
Nov 28, 2023
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
613a588 to
487fe23
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
487fe23 to
3c90065
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
3c90065 to
6d4b6b9
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Nov 28, 2023
| @@ -33,6 +33,21 @@ async fn virtual_hosted_buckets() { | |||
| ); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn no_path_rewriting() { | |||
There was a problem hiding this comment.
Unrelated to the rest of the PR?
| @@ -476,6 +476,7 @@ class ServiceConfigGenerator( | |||
| docs("Apply test defaults to the builder") | |||
| rustBlock("pub fn apply_test_defaults(&mut self) -> &mut Self") { | |||
| customizations.forEach { it.section(ServiceConfig.DefaultForTests("self"))(this) } | |||
| rustTemplate("self.behavior_version = Some(crate::config::BehaviorVersion::latest());") | |||
There was a problem hiding this comment.
Should use #{Some} for collision avoidance.
codegen-core/build.gradle.kts
Outdated
| @@ -52,19 +52,49 @@ fun gitCommitHash(): String { | |||
| } | |||
| } | |||
|
|
|||
| fun kv(key: String, value: String) = """"$key": "$value"""" | |||
There was a problem hiding this comment.
Nit: put this inside of the block so it is scoped to it
| version.append(kv("stableVersion", stableCrateVersion)).append(",") | ||
| version.append(kv("unstableVersion", unstableCrateVersion)).append(",") | ||
| // hack for internal build | ||
| val smithyStableCrates = listOf( |
There was a problem hiding this comment.
At what point do we put this metadata in the runtime crate Cargo.tomls and resolve it automatically?
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Nov 28, 2023
When the stable/unstable crate versions were split, this caused a regression in determining the crate version during codegen. This enhances our crate-version forwarding code to publish all the crate versions. For impact, see codegen-client-test.
rcoh
force-pushed
the
fix-runtime-crate-versions
branch
from
53de7e5 to
74cf401
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
pushed a commit
that referenced
this pull request
Dec 1, 2023
## Motivation and Context When the stable/unstable crate versions were split, this caused a regression in determining the crate version during codegen. This enhances our crate-version forwarding code to publish all the crate versions. For impact, see codegen-client-test. ## Description - Change the build artifact to be a JSON blob will all required versions. ## Testing - [ ] Audit diff ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
rcoh
added a commit
that referenced
this pull request
Dec 1, 2023
## Motivation and Context When the stable/unstable crate versions were split, this caused a regression in determining the crate version during codegen. This enhances our crate-version forwarding code to publish all the crate versions. For impact, see codegen-client-test. ## Description - Change the build artifact to be a JSON blob will all required versions. ## Testing - [ ] Audit diff ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When the stable/unstable crate versions were split, this caused a regression in determining the crate version during codegen. This enhances our crate-version forwarding code to publish all the crate versions. For impact, see codegen-client-test.
Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.