Improve error when service is missing protocol #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to implement this as a Thanks. |
djedward
force-pushed
the
main-issue2452
branch
2 times, most recently
from
9343a39 to
9b3b33a
Compare
resolves smithy-lang#2452 ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
|
Sure, I can look into that. |
|
An internal user also reported that the error was confusing because they didn't know what these protocols were about. We could link for each protocol its doc page under https://smithy.io/2.0/aws/protocols/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2452
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Motivation and Context
Issue 2452
Description
This change updates the error message received when the model is missing a protocol or the protocol specified isn't found. The issue recommended adding some line breaks/wording changes. More than happy to adjust the formatting/wording as desired. This is what they look like now:
Testing
Added 3 new tests to cover success, missing protocol and no matching protocol
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.