exclude invoke operations from SSP #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
suggestion: I wonder if a more generalized DisableStalledStreamProtectionDecorator that centralizes this wouldn't be better. We'd add the existing S3 operation and the new Lambda ones to a single decorator.
I'm not going to block on this as this works but an alternative to consider that may be better for long term maintenance and discoverability.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Jun 13, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
aws-sdk-rust#1166
Description
SSP shouldn't be enabled for long-running operations that transfer no data.
Testing
Checked the generated lambda SDK to see that SSP has been disabled for the operations specified.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.