Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace serde_cbor with ciborium due to security vulnerability #3855

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Replace serde_cbor with ciborium due to security vulnerability #3855

merged 8 commits into from
Oct 2, 2024

Conversation

drganjoo
Copy link
Contributor

@drganjoo drganjoo commented Oct 1, 2024

  • serde_cbor is unmaintained and has known security issues
  • ciborium is an actively maintained CBOR library

Closes Issue: #3853

Replace serde_cbor with ciborium due to security vulnerability
20ff1c7 
- `serde_cbor` is unmaintained and has known [security issues](https://rustsec.org/advisories/RUSTSEC-2021-0127.html)
- `ciborium` is an actively maintained CBOR library
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@drganjoo drganjoo linked an issue Oct 2, 2024 that may be closed by this pull request
Replace serde_cbor with ciborium due to security advisory #3853
Closed
@drganjoo drganjoo marked this pull request as ready for review October 2, 2024 06:13
@drganjoo drganjoo requested review from a team as code owners October 2, 2024 06:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@aws-sdk-rust-ci aws-sdk-rust-ci merged commit 3871e9a into main Oct 2, 2024
44 checks passed
@aws-sdk-rust-ci aws-sdk-rust-ci deleted the fahadzub/ciborium branch October 2, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-perez david-perez david-perez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace serde_cbor with ciborium due to security advisory
3 participants
@drganjoo @david-perez @aws-sdk-rust-ci