Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RDS URL signer #3867

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Add RDS URL signer #3867

merged 9 commits into from
Oct 17, 2024

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Oct 7, 2024

Motivation and Context

aws-sdk-rust/951

Description

Adds a struct for generating signed URLs for logging in to RDS. See this doc for more info.

Testing

I wrote a test.

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested a review from a team as a code owner October 7, 2024 15:34
@Velfi Velfi mentioned this pull request Oct 7, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

aajtodd
aajtodd reviewed Oct 7, 2024
View reviewed changes
aws/rust-runtime/aws-inlineable/Cargo.toml Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-checksums/src/lib.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/rds_signer.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/rds_signer.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001
ysaito1001 reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure utilizing aws-inlineable looks good 👍 Left a few comments.

aws/rust-runtime/aws-inlineable/src/rds_auth_token.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/rds_auth_token.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/rds_auth_token.rs Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/rds_auth_token.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi enabled auto-merge October 17, 2024 15:25
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit c8c610f Oct 17, 2024
44 checks passed
@Velfi Velfi deleted the zhessler-add-rds-signer branch October 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajtodd aajtodd aajtodd left review comments

@ysaito1001 ysaito1001 ysaito1001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velfi @aajtodd @ysaito1001