Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen-serde: traverse operations of resources #3882

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

david-perez
Copy link
Contributor

The current implementation doesn't traverse a resource's operations if
the serialization root is a service shape; the added test fails without
this fix.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The current implementation doesn't traverse a resource's operations if
the serialization root is a service shape; the added test fails without
this fix.
@david-perez david-perez requested a review from a team as a code owner October 17, 2024 15:01
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@david-perez david-perez added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit eb48261 Oct 17, 2024
44 checks passed
@david-perez david-perez deleted the davidpz/serde-consider-all-operations branch October 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants