Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library dependency issues #3901

Merged
merged 6 commits into from
Nov 5, 2024
+38 −3
Merged

Fix library dependency issues #3901

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3318ee
Place SDK lockfile in adhoc tests
ysaito1001 Nov 4, 2024
9fe98a8
Place Smithy runtime lockfile in codegen-client-test
ysaito1001 Nov 4, 2024
e931b60
Copy SDK lockfile to `aws-sdk-rust` during `check-semver-hazards`
ysaito1001 Nov 4, 2024
21d45a9
Pin `arbitrary` due to the use of `error_in_core`
ysaito1001 Nov 4, 2024
81d2e74
Do not run `cargo generate-lockfile` before `cargo semver-checks`
ysaito1001 Nov 5, 2024
da94833
Move `generateCargoWorkspace` to `finalizedBy`
ysaito1001 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not run cargo generate-lockfile before cargo semver-checks
@ysaito1001
ysaito1001 committed Nov 5, 2024
commit 81d2e74f34e6c2bc53496a220aa8bd32faa28666
1 change: 0 additions & 1 deletion tools/ci-scripts/codegen-diff/semver-checks.py
View file
Original file line number Diff line number Diff line change
@@ -44,7 +44,6 @@ def main(skip_generation=False):
elif get_cmd_status(f'git cat-file -e base:{sdk_directory}/{path}/Cargo.toml') != 0:
eprint(f'skipping {path} because it does not exist in base')
else:
get_cmd_output('cargo generate-lockfile', quiet=True)
(_, out, _) = get_cmd_output('cargo pkgid', cwd=path, quiet=True)
pkgid = parse_package_id(out)
(status, out, err) = get_cmd_output(f'cargo semver-checks check-release '