Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zhessler add dsql auth token generator #3927

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Dec 3, 2024

Description

This adds an auth token generator that works like the existing RDS auth token generator, but for a new service: DSQL.

To generate the DSQL SDK, run this command from the root of the project:

./gradlew :aws:sdk:assemble -Paws.services=+sts,+sso,+ssooidc,+dsql

Then, to run the auth token generator tests:

cd aws/sdk/build/aws-sdk/sdk/dsql
cargo test signing_works --all-features

Testing

tests are included in the inlineable

Checklist

  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested review from a team as code owners December 3, 2024 15:20
Copy link

github-actions bot commented Dec 3, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • Client Test (ignoring whitespace)
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For server codegen CI failure, I think it'll go away if we just re-run failed job.

.changelog/1733238900.md Outdated Show resolved Hide resolved
aws/rust-runtime/aws-inlineable/src/dsql_auth_token.rs Outdated Show resolved Hide resolved
Velfi and others added 2 commits December 3, 2024 08:41
Co-authored-by: ysaito1001 <awsaito@amazon.com>
@Velfi Velfi enabled auto-merge December 3, 2024 16:44
Copy link

github-actions bot commented Dec 3, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • Client Test (ignoring whitespace)
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi disabled auto-merge December 3, 2024 17:12
@Velfi Velfi enabled auto-merge December 3, 2024 17:12
Copy link

github-actions bot commented Dec 3, 2024

A new generated diff is ready to view.

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 039177d Dec 3, 2024
43 of 44 checks passed
@Velfi Velfi deleted the zhessler-add-dsql-auth-token-generator branch December 3, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants