Update CBOR to always have an accept header #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
approved these changes
Oct 15, 2024
alextwoods
approved these changes
Oct 15, 2024
|
Yes. Still needs Smithy update. |
alextwoods
approved these changes
Oct 18, 2024
| @@ -1,6 +1,8 @@ | |||
| Unreleased Changes | |||
| ------------------ | |||
|
|
|||
| * Issue - Support services migrating from AWS Query to AWS JSON or RPC v2. | |||
There was a problem hiding this comment.
This AWS specific bit is kind of weird to have in our generic changelog.
There was a problem hiding this comment.
Yeah. I can change this "from AWS Query to RPC v2" - the query trait (AWS) is used generically now so that bit must stay.
| TreeSet<Shape> shapesToRender = CodegenUtils.getAlphabeticalOrderedShapesSet(); | ||
| TreeSet<Shape> eventStreamEventsToRender = CodegenUtils.getAlphabeticalOrderedShapesSet(); | ||
|
|
||
| Comparator<Shape> comparator = Comparator.comparing(o -> o.getId().getName() + " " + o.getId()); |
There was a problem hiding this comment.
Why this change? The codegenutils helper method for this seems cleaner than implementing a comparator for each one?
There was a problem hiding this comment.
It was the only method in the utility after unused methods cleaned up. It felt weird and was used in 3 classes. I think it's fine to duplicate it here as we've effectively duplicated the same logic for iterating shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to update Smithy and test against protocol tests.