feat: Make lots of types Sendable #1009
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
requested changes
Dec 15, 2025
| fun render(serviceSymbol: Symbol) { | ||
| writer.openBlock( | ||
| "${ctx.settings.visibility} class \$L: \$N {", | ||
| "${ctx.settings.visibility} final class \$L: \$N, Sendable {", |
Contributor
There was a problem hiding this comment.
See my note on the other PR, rather than mark Sendable here (and on every generated client) I think we can just specify that ClientRuntime.Client conforms to Sendable
|
|
||
| writer.openBlock( | ||
| "public class \$LConfiguration: \$L {", | ||
| "public final class \$LConfiguration: \$L, @unchecked Sendable {", |
Contributor
There was a problem hiding this comment.
Also see my note on the other PR, even after applying final this type is not Sendable (checked or unchecked)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.