Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate convert html to markdown for generated docs #381

Merged
merged 5 commits into from
Oct 29, 2021

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Oct 27, 2021

Some good progress on creating links, but need to:

  • Write a bunch of unit tests
  • Move stripping logic to the actual DocumentationConverter
  • Make sure all the services still compile!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 marked this pull request as ready for review October 28, 2021 22:57
@wooj2 wooj2 requested a review from kneekey23 October 28, 2021 22:57
Copy link
Contributor

@kneekey23 kneekey23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wooj2 wooj2 merged commit 769bb62 into main Oct 29, 2021
@wooj2 wooj2 deleted the feat/mdDocsGen branch October 29, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants