Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cbor): add protocol resolution priority system #1370

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 16, 2024

  • adds a system for Protocol selection that has a notion of priority.
  • adds an API for controlling overrides to the global priority order and service-specific priority ordering of Protocols

Example Scenario:

Smithy-TS only has 1 inherent protocol at the moment, RPCv2 CBOR.

AWS consumer may want to set a default priority order of JSON->CBOR->XML etc.
Specific AWS services that support both JSON and CBOR may want to prioritize differently from each other.

@kuhe kuhe requested review from a team as code owners August 16, 2024 20:17
@kuhe kuhe requested a review from sugmanue August 16, 2024 20:17
@kuhe
Copy link
Contributor Author

kuhe commented Aug 16, 2024

prior: #1280

downstream: aws/aws-sdk-js-v3#6096

@sugmanue sugmanue self-requested a review August 19, 2024 19:05
@kuhe kuhe merged commit 8b3d752 into smithy-lang:main Aug 19, 2024
11 checks passed
@kuhe kuhe deleted the feat/cbor2 branch August 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants