Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use typeof inputTokenName as token type instead of string #248

Merged

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Dec 14, 2020

Issue #, if available:
Fixes: aws/aws-sdk-js-v3#1782

Description of changes:
use typeof inputTokenName as token type instead of string

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the use-typeof-inputTokenName-for-token branch from f4ca13b to 5349598 Compare December 14, 2020 16:44
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit a0c77ea into smithy-lang:master Dec 14, 2020
@trivikr trivikr deleted the use-typeof-inputTokenName-for-token branch December 14, 2020 16:54
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
srchase pushed a commit that referenced this pull request Mar 23, 2023
* chore: add Greenkeeper config file

* chore(package): update dependencies

* docs(readme): add Greenkeeper badge

* chore: ignore jest, @types/node, yargs in initial greenkeeper config

* chore: fix for error `(err?: Error | undefined) => void`

* fix: property 'port' does not exist on type 'string'
srchase pushed a commit that referenced this pull request Jun 16, 2023
* chore: add Greenkeeper config file

* chore(package): update dependencies

* docs(readme): add Greenkeeper badge

* chore: ignore jest, @types/node, yargs in initial greenkeeper config

* chore: fix for error `(err?: Error | undefined) => void`

* fix: property 'port' does not exist on type 'string'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination doesn't support a complex data type for token
2 participants