Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix response payload and incorrectly parsing error response #63

Merged
merged 4 commits into from
Dec 27, 2019

Commits on Dec 24, 2019

  1. Configuration menu
    Copy the full SHA
    0dbd1d3 View commit details
    Browse the repository at this point in the history
  2. add support for parsing body in either dispatcher or deser

    For some protocols, error type flag exists in error response body,
    then we need to collect response stream to JS object and parse the
    error type; For other protocols, error type flag doesn't exist in
    error response body, then we don't need to collect the response
    stream in error dispatcher. Instead, we can treat the error like
    normal response. So that error shape supports the same traits as
    normal responses like streaming, payload etc.
    
    This is done by add a new flag in Protocol generator--
    isErrorCodeInBody. When it return true, it means error type flag
    exists in error response body, then body is parsed in errors
    dispatcher, and each error deser only need to deal with parsed
    response body in JS object format. When it returns false, it means
    error type can be inferred without touching response body, then
    error deser can access the error response intact.
    AllanZhengYP committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    c9454c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2019

  1. Configuration menu
    Copy the full SHA
    7058dc6 View commit details
    Browse the repository at this point in the history
  2. add response body string to unknown error message

    If incoming error response is unknow error, we only make best effort
    to infer the error type. This change puts error response body to error
    message so that users have the information they need. This change is
    necessary for Node because when error response is unknown, the body
    stream will never be consumed, which would use a lot of resources
    before stream is flushed.
    AllanZhengYP committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    6f4f986 View commit details
    Browse the repository at this point in the history