Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix response payload and incorrectly parsing error response #66

Merged
merged 8 commits into from
Jan 10, 2020

Commits on Jan 9, 2020

  1. Configuration menu
    Copy the full SHA
    a1cc249 View commit details
    Browse the repository at this point in the history
  2. add support for parsing body in either dispatcher or deser

    For some protocols, error type flag exists in error response body,
    then we need to collect response stream to JS object and parse the
    error type; For other protocols, error type flag doesn't exist in
    error response body, then we don't need to collect the response
    stream in error dispatcher. Instead, we can treat the error like
    normal response. So that error shape supports the same traits as
    normal responses like streaming, payload etc.
    
    This is done by add a new flag in Protocol generator--
    isErrorCodeInBody. When it return true, it means error type flag
    exists in error response body, then body is parsed in errors
    dispatcher, and each error deser only need to deal with parsed
    response body in JS object format. When it returns false, it means
    error type can be inferred without touching response body, then
    error deser can access the error response intact.
    AllanZhengYP committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    025ee8d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c30b647 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b95f089 View commit details
    Browse the repository at this point in the history
  5. address feedbacks

    AllanZhengYP committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    64167aa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f198929 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cd40b1e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. add more commentaries

    AllanZhengYP committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    648663f View commit details
    Browse the repository at this point in the history