Skip to content

Commit

Permalink
Undo changes to createNode for Traits that used NodeMapper
Browse files Browse the repository at this point in the history
They are fixed via #865
  • Loading branch information
gosar authored and JordonPhillips committed Jul 21, 2021
1 parent 4b9a307 commit 20e4eea
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@ protected ObjectNode createNode() {
NodeMapper mapper = new NodeMapper();
mapper.disableToNodeForClass(IntegrationTrait.class);
mapper.setOmitEmptyValues(true);
ObjectNode.Builder builder = mapper.serialize(this).expectObjectNode().toBuilder();
return builder.sourceLocation(getSourceLocation()).build();
return mapper.serialize(this).expectObjectNode();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ protected ObjectNode createNode() {
NodeMapper mapper = new NodeMapper();
mapper.disableToNodeForClass(MockIntegrationTrait.class);
mapper.setOmitEmptyValues(true);
ObjectNode.Builder builder = mapper.serialize(this).expectObjectNode().toBuilder();
return builder.sourceLocation(getSourceLocation()).build();
return mapper.serialize(this).expectObjectNode();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import java.util.Optional;
import software.amazon.smithy.model.node.Node;
import software.amazon.smithy.model.node.NodeMapper;
import software.amazon.smithy.model.node.ObjectNode;
import software.amazon.smithy.model.shapes.ShapeId;
import software.amazon.smithy.model.traits.AbstractTrait;
import software.amazon.smithy.model.traits.AbstractTraitBuilder;
Expand Down Expand Up @@ -72,8 +71,7 @@ protected Node createNode() {
NodeMapper mapper = new NodeMapper();
mapper.disableToNodeForClass(CfnResourceTrait.class);
mapper.setOmitEmptyValues(true);
ObjectNode.Builder builder = mapper.serialize(this).expectObjectNode().toBuilder();
return builder.sourceLocation(getSourceLocation()).build();
return mapper.serialize(this).expectObjectNode();
}

@Override
Expand Down

0 comments on commit 20e4eea

Please sign in to comment.