Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for example of nested wrapped/flattened maps in Protocol tests for RestXml #748

Closed
wooj2 opened this issue Mar 23, 2021 · 0 comments · Fixed by #777
Closed

Request for example of nested wrapped/flattened maps in Protocol tests for RestXml #748

wooj2 opened this issue Mar 23, 2021 · 0 comments · Fixed by #777
Labels
protocol-test New protocol tests are needed

Comments

@wooj2
Copy link
Contributor

wooj2 commented Mar 23, 2021

Hi,

Would it be possible to add a test case in the protocol tests to generate a test for both a nested wrapped map, and a nested flattened map?

In the case of nested list work, the RestXml tests seem to have this example:
https://github.com/awslabs/smithy/blob/3488bf6e742d6a56443267f5697bcecffff6064b/smithy-aws-protocol-tests/model/restXml/document-lists.smithy#L297

And ideally, we would have something similar for maps.

Thanks!

@JordonPhillips JordonPhillips added the protocol-test New protocol tests are needed label Apr 20, 2021
JordonPhillips added a commit to JordonPhillips/smithy that referenced this issue Apr 22, 2021
JordonPhillips added a commit that referenced this issue Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol-test New protocol tests are needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants