Add protocol tests for default values #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Oct 6, 2023
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
5 times, most recently
from
88abc9b to
881a441
Compare
mtdowling
requested changes
Oct 11, 2023
smithy-aws-protocol-tests/model/awsJson1_0/nestedDefaults.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-protocol-tests/model/awsJson1_0/nestedDefaults.smithy
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
2 times, most recently
from
aea9acf to
3a778f5
Compare
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
from
3a778f5 to
6b5ec17
Compare
kstich
requested changes
Oct 16, 2023
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
from
6b5ec17 to
6e3c00c
Compare
kstich
approved these changes
Oct 24, 2023
mtdowling
requested changes
Oct 24, 2023
smithy-aws-protocol-tests/model/awsJson1_0/nestedDefaults.smithy
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
4 times, most recently
from
08e70be to
39f2b0b
Compare
AndrewFossAWS
force-pushed
the
default-protocol-tests
branch
from
39f2b0b to
d4d5462
Compare
mtdowling
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.